Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize ITs to run with concurrent search enabled #9441

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Parameterize ITs to run with concurrent search enabled #9441

merged 3 commits into from
Sep 15, 2023

Conversation

harishbhakuni
Copy link
Contributor

@harishbhakuni harishbhakuni commented Aug 18, 2023 •
edited
Loading

Description

Parameterizing first batch of ITs with concurrent search enabled as part of this PR.
List of ITs Parameterized in this PR:

1. IndicesRequestCacheIT
2. IndexStatsIT
3. ScriptCacheIT
4. StressSearchServiceReaperIT
5. DeletePitMultiNodeIT
6. PitMultiNodeIT
7. ScriptQuerySearchIT
8. DuelScrollIT
9. SearchScrollIT
10. SearchScrollWithFailingNodesIT
11. SearchAfterIT
12. GeoDistanceIT
13. GeoDistanceSortBuilderIT
14. SortFromPluginIT
15. CompletionSuggestSearchIT
16. ContextCompletionSuggestSearchIT
17. SuggestSearchIT
18. SimilarityIT

Related Issues

#9443

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change ba78d93

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal
Copy link
Contributor

@harishbhakuni thanks for the changes, it would be good to add the classes for which we are adding the parameterization in the pr description.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change acbd7b5

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #9441 (98902c5) into main (e6dec29) will increase coverage by 0.14%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 98902c5 differs from pull request most recent head acbd7b5. Consider uploading reports for the commit acbd7b5 to get more accurate results

@@             Coverage Diff              @@
##               main    #9441      +/-   ##
============================================
+ Coverage     71.03%   71.18%   +0.14%     
- Complexity    58071    58115      +44     
============================================
  Files          4824     4824              
  Lines        273918   273915       -3     
  Branches      39918    39917       -1     
============================================
+ Hits         194591   194988     +397     
+ Misses        63017    62544     -473     
- Partials      16310    16383      +73

see 476 files with indirect coverage changes

@sohami
Copy link
Collaborator

sohami commented Sep 14, 2023

@harishbhakuni There is a conflict with server/src/internalClusterTest/java/org/opensearch/search/sort/GeoDistanceIT.java, can you please resolve that

Harish Bhakuni added 3 commits September 14, 2023 16:30
Parameterize ITs to run with concurrent search enabled
4d84b11 
Signed-off-by: Harish Bhakuni <[email protected]>
Address PR Changes
9884933 
Signed-off-by: Harish Bhakuni <[email protected]>
Address PR Comments
acbd7b5 
Signed-off-by: Harish Bhakuni <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@harishbhakuni
Copy link
Contributor Author

below tests are failing in gradle check and are marked flaky (not able to reproduce them in local):
org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled: #5957
org.opensearch.indices.replication.SegmentReplicationSuiteIT.classMethod: #9499
org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting: #2348

@sohami sohami added the backport 2.x Backport to 2.x branch label Sep 15, 2023
@sohami sohami merged commit 7d1fa7d into opensearch-project:main Sep 15, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 15, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 15, 2023
@github-actions
Parameterize ITs to run with concurrent search enabled (#9441)
45b7372 
* Parameterize ITs to run with concurrent search enabled

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Changes

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Comments

Signed-off-by: Harish Bhakuni <[email protected]>

---------

Signed-off-by: Harish Bhakuni <[email protected]>
Co-authored-by: Harish Bhakuni <[email protected]>
(cherry picked from commit 7d1fa7d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sohami pushed a commit that referenced this pull request Sep 15, 2023
@opensearch-trigger-bot @github-actions
Parameterize ITs to run with concurrent search enabled (#9441) (#10062)
bc419b4 
* Parameterize ITs to run with concurrent search enabled



* Address PR Changes



* Address PR Comments



---------



(cherry picked from commit 7d1fa7d)

Signed-off-by: Harish Bhakuni <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Harish Bhakuni <[email protected]>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
@harishbhakuni @sarthakaggarwal97
Parameterize ITs to run with concurrent search enabled (opensearch-pr…
37ec344 
…oject#9441)

* Parameterize ITs to run with concurrent search enabled

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Changes

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Comments

Signed-off-by: Harish Bhakuni <[email protected]>

---------

Signed-off-by: Harish Bhakuni <[email protected]>
Co-authored-by: Harish Bhakuni <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@harishbhakuni @brusic
Parameterize ITs to run with concurrent search enabled (opensearch-pr…
0d2132f 
…oject#9441)

* Parameterize ITs to run with concurrent search enabled

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Changes

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Comments

Signed-off-by: Harish Bhakuni <[email protected]>

---------

Signed-off-by: Harish Bhakuni <[email protected]>
Co-authored-by: Harish Bhakuni <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
@harishbhakuni @vikasvb90
Parameterize ITs to run with concurrent search enabled (opensearch-pr…
0c66f7a 
…oject#9441)

* Parameterize ITs to run with concurrent search enabled

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Changes

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Comments

Signed-off-by: Harish Bhakuni <[email protected]>

---------

Signed-off-by: Harish Bhakuni <[email protected]>
Co-authored-by: Harish Bhakuni <[email protected]>
@Rishikesh1159 Rishikesh1159 mentioned this pull request Jan 9, 2024
Closed
12 tasks
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@harishbhakuni @shiv0408
Parameterize ITs to run with concurrent search enabled (opensearch-pr…
8a52988 
…oject#9441)

* Parameterize ITs to run with concurrent search enabled

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Changes

Signed-off-by: Harish Bhakuni <[email protected]>

* Address PR Comments

Signed-off-by: Harish Bhakuni <[email protected]>

---------

Signed-off-by: Harish Bhakuni <[email protected]>
Co-authored-by: Harish Bhakuni <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jed326 jed326 jed326 left review comments

@neetikasinghal neetikasinghal neetikasinghal left review comments

@sohami sohami sohami approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@peternied peternied Awaiting requested review from peternied

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harishbhakuni @neetikasinghal @sohami @jed326